feat: add smtp auth login support #683
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Extremely easy PR for you @foxcpp :) |
|
Needs corresponding documentation update |
|
@foxcpp Done! |
foxcpp
requested changes
Feb 25, 2024
buroa
force-pushed
the
master
branch
2 times, most recently
from
0b883ed
to
a87a9c0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #683 +/- ##
=======================================
Coverage 52.38% 52.38%
=======================================
Files 128 128
Lines 13382 13389 +7
=======================================
+ Hits 7010 7014 +4
- Misses 5707 5711 +4
+ Partials 665 664 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Let me add some tests as well @foxcpp. |
onedr0p
approved these changes
Feb 25, 2024
|
@foxcpp Ready for you. |
Signed-off-by: Steven Kreitzer <[email protected]>
|
@foxcpp Can we get this merged? |
onedr0p
approved these changes
May 31, 2024
|
@foxcpp Ping |
|
Closing this. Doubt it'll be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This let's providers like
smtp.office365.comwork.